Changeset 243

Show
Ignore:
Timestamp:
04/08/09 18:09:40 (15 years ago)
Author:
bhilburn
Message:

Realized that there isn't a memory leak. Just really, really confusing
code.

Files:
1 modified

Legend:

Unmodified
Added
Removed

  • vtcross/branches/fixingCBR/src/include/vtcross/cbr.h

    r241 r243  
    4141 
    4242/* TODO This is a terribly hackish way to go about this. Why not just use actual 
    43  * pointers? Typedefing the pointer out makes the code misleading and hard to 
    44  * understand. 
     43 * pointers? Typedefing the pointer out makes the code misleading and extremely  
     44 * difficult to understand. 
    4545 */ 
    4646typedef cbr_s * cbr; 
    4747 
    4848 
    49 /* TODO I don't think these functions do what you want them to do.  The 
    50  * cbr_create is returning an object by value, which means the object that is 
    51  * being malloc'd in the cbr_create function is effectively a memory leak, since 
    52  * you lose the reference to that memory, and instead return a copy of the data 
    53  * in that memory space. 
     49/* TODO 
    5450 */ 
    5551cbr cbr_create(char * _filename, char * _tablename, char * _cols[], \